Skip to content

Fix old usage of error_code#710

Merged
Taucher2003 merged 1 commit intomainfrom
fix-old-error-code-usage
Nov 22, 2025
Merged

Fix old usage of error_code#710
Taucher2003 merged 1 commit intomainfrom
fix-old-error-code-usage

Conversation

@Knerio
Copy link
Copy Markdown
Member

@Knerio Knerio commented Nov 22, 2025

No description provided.

@Knerio Knerio self-assigned this Nov 22, 2025
@Knerio Knerio changed the title Change old use of payload: to error_code: Fix old usage of error_code Nov 22, 2025
Copilot AI reviewed Nov 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a ServiceResponse.error call to use the correct error_code: parameter instead of the deprecated payload: parameter, aligning with the ServiceResponse API requirements.

Key Changes:

  • Corrected parameter name from payload: to error_code: in the error response when backup code generation fails

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Knerio Knerio marked this pull request as draft November 22, 2025 19:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 22, 2025 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2173802719

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12183701782/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2173802719/test_report
Finished in 19.87 seconds (files took 10.5 seconds to load)
1217 examples, 0 failures
Line Coverage: 91.33% (4119 / 4510)
[TEST PROF INFO] Time spent in factories: 00:10.666 (41.86% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12183701780/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2173802719/test_report
Finished in 18.79 seconds (files took 11.17 seconds to load)
1170 examples, 0 failures
Line Coverage: 90.72% (3951 / 4355)
[TEST PROF INFO] Time spent in factories: 00:10.397 (41.29% of total time)

rubocop

683 files inspected, no offenses detected

@Knerio Knerio force-pushed the fix-old-error-code-usage branch 2 times, most recently from c4ad297 to acd549c Compare November 22, 2025 19:58
@Knerio Knerio marked this pull request as ready for review November 22, 2025 19:58
@Knerio Knerio requested a review from Copilot November 22, 2025 19:58
@Knerio Knerio force-pushed the fix-old-error-code-usage branch from acd549c to f9ac51d Compare November 22, 2025 19:59
Copilot AI reviewed Nov 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Taucher2003 Taucher2003 merged commit eab25c3 into main Nov 22, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the fix-old-error-code-usage branch November 22, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Taucher2003 Taucher2003 Taucher2003 approved these changes

Assignees

@Knerio Knerio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Knerio @Taucher2003