Fix grpc errors #728
Fix grpc errors #728
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves error handling and logging in gRPC data type-related services. The changes add structured error logging, introduce a new error code for flow type validation failures, and fix data type rule serialization to properly handle generic type identifiers.
- Enhanced error handling with detailed logging across three update services (RuntimeFunctionDefinitions, FlowTypes, DataTypes)
- Added
invalid_flow_typeerror code for consistency with other validation error patterns - Fixed data type rule serialization to properly handle
DataTypeIdentifierobjects with generic keys
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/services/runtimes/runtime_function_definitions/update_service.rb | Added logging module inclusion, error logging with context, and success logging; added error_code to error responses |
| app/services/runtimes/flow_types/update_service.rb | Added logging module inclusion, error logging with context; added error_code to error responses; fixed update_flowtype to return db_object |
| app/services/runtimes/data_types/update_service.rb | Added logging module inclusion, error logging with context, and success logging; fixed update_datatype to return db_object; enhanced update_rules to properly serialize DataTypeIdentifier objects |
| app/services/error_code.rb | Added invalid_flow_type error code definition |
| docs/graphql/enum/errorcodeenum.md | Documented INVALID_FLOW_TYPE error code enum value |
| app/grpc/data_type_handler.rb | Removed redundant logging module and logger.info call (moved to service layer) |
| spec/requests/grpc/sagittarius/data_type_service_spec.rb | Updated test to use contains_type rule with generic_key instead of number_range rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2183281159 Status: Passed Job summariesrspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12243457783/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12243457778/artifacts/tmp/coverage/index.html rubocop698 files inspected, no offenses detected |
Knerio
force-pushed
the
fix-grpc-errors
branch
from
60387cd to
9efe9d5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Knerio
force-pushed
the
fix-grpc-errors
branch
from
311dfba to
6fe50bf
Compare
Will pass with: code0-tech/tucana#159
close #729