Skip to content

Update code0 flow#145

Merged
raphael-goetz merged 2 commits intomainfrom
deps/update-code0-flow
Apr 12, 2026
Merged

Update code0 flow#145
raphael-goetz merged 2 commits intomainfrom
deps/update-code0-flow

Conversation

@raphael-goetz
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 12, 2026 10:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Taurus’s dynamic flow sync to work with the newer code0-flow release by introducing an Aquila token configuration and passing it into the flow update client.

Changes:

  • Bump code0-flow dependency from 0.0.29 to 0.0.30.
  • Add AQUILA_TOKEN to Taurus config and pass it into FlowUpdateService::from_url(...).
  • Refresh Cargo.lock to reflect the updated dependency graph.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
crates/taurus/src/main.rs Passes Aquila token into flow update sync during DYNAMIC startup.
crates/taurus/src/config/mod.rs Adds aquila_token to Config and loads it from AQUILA_TOKEN.
Cargo.toml Bumps code0-flow workspace dependency version.
Cargo.lock Updates lockfile for code0-flow 0.0.30 and related deps.
Comments suppressed due to low confidence (1)

crates/taurus/src/config/mod.rs:50

  • AQUILA_TOKEN defaults to the literal value "token". That makes it easy to accidentally run with an invalid/predictable credential (and can hide misconfiguration in production). Prefer defaulting to an empty string/None and explicitly failing (or warning) when running in DYNAMIC mode without a real token, depending on whether auth is required.
            nats_url: env_with_default("NATS_URL", String::from("nats://localhost:4222")),
            aquila_url: env_with_default("AQUILA_URL", String::from("http://localhost:50051")),
            aquila_token: env_with_default("AQUILA_TOKEN", String::from("token")),
            with_health_service: env_with_default("WITH_HEALTH_SERVICE", false),
            grpc_host: env_with_default("GRPC_HOST", "127.0.0.1".to_string()),
            grpc_port: env_with_default("GRPC_PORT", 50051),
            definitions: env_with_default("DEFINITIONS", String::from("./definitions")),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -110,6 +110,7 @@ async fn main() {
FlowUpdateService::from_url(
config.aquila_url.clone(),
config.definitions.clone().as_str(),
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.definitions.clone().as_str() creates an unnecessary temporary String just to immediately borrow it. Prefer borrowing the existing String (e.g., config.definitions.as_str() / &config.definitions) to reduce allocations and avoid confusing temporary-borrow patterns around an .await.

Suggested change
config.definitions.clone().as_str(),
config.definitions.as_str(),

Copilot uses AI. Check for mistakes.
@raphael-goetz raphael-goetz merged commit 881b1fc into main Apr 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants