Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #149 by allowing http::response::create to accept an integer HTTP status code (instead of a string), aligning runtime argument parsing with how numeric literals are represented.
Changes:
- Update
http::response::createto takehttp_status_codeasi64and store it directly as a numericstatus_code. - Add
TryFromArgument for i64so runtime functions can requesti64-typed parameters. - Update flow fixtures to pass
http_status_codeas anumberValue.integerinstead of astringValue.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flows/01_return_object.json | Updates http_status_code literal from string to numeric integer in the test flow. |
| flows/02_return_flow_input.json | Updates http_status_code literal from string to numeric integer in the test flow. |
| crates/core/src/runtime/functions/http.rs | Changes http::response::create to accept an i64 status code and emit it as a numeric value. |
| crates/core/src/context/argument.rs | Adds TryFromArgument support for extracting i64 from NumberValue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #149