Migrate HTTP runtime to ureq v3 API#198
Merged
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2539431003 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14457113525/artifacts/out/index.html |
Agent-Logs-Url: https://github.com/code0-tech/taurus/sessions/e7ff2af7-5fa3-402f-8d1d-2da327e70630 Co-authored-by: raphael-goetz <52959657+raphael-goetz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Rust crate ureq to v3
Migrate HTTP runtime to ureq v3 API
May 20, 2026
raphael-goetz
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the standard-functions HTTP runtime (http::request::send) to the ureq v3 request/response API, keeping the existing semantics around accepting non-2xx status codes and decoding headers/payloads.
Changes:
- Build requests via
ureq::http::Request(method parsing, URI, headers) and execute viaRequestExtwithhttp_status_as_error(false)andallow_non_standard_methods(true). - Update response handling to work with
http::Response<Body>, including header iteration and payload reading via the v3 body reader.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+165
to
+168
| Err(_) => { | ||
| return fail( | ||
| "InvalidArgumentRuntimeError", | ||
| format!("Invalid HTTP method '{}'", method), |
Comment on lines
+190
to
+194
| .with_default_agent() | ||
| .configure() | ||
| .http_status_as_error(false) | ||
| .allow_non_standard_methods(true) | ||
| .run() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to ureq v3 required updating the HTTP runtime request/response handling to the new API surface while preserving existing behavior (non-error status handling, header/payload decoding).
http::Requestdirectly, parse method, apply headers, and configure ureq to accept non-standard methods and non-error status codes.http::Response<Body>and decode headers/payload via the new body reader.