Change version to a string #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies version representation by replacing the structured Version message with a simple string format across all protobuf definitions.
- Removed the
shared.version.protofile containing the structured Version message (major, minor, patch fields) - Updated three message definitions to use string-based version field with clear format documentation
- Removed all imports of the deprecated version proto file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/shared/shared.version.proto | Deleted the entire file containing the structured Version message definition |
| proto/shared/shared.runtime_function.proto | Changed RuntimeFunctionDefinition.version from shared.Version to string with format documentation, removed version proto import |
| proto/shared/shared.flow_definition.proto | Changed FlowType.version from shared.Version to string with format documentation, removed version proto import |
| proto/shared/shared.data_type.proto | Changed DefinitionDataType.version from shared.Version to string with format documentation, removed version proto import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Taucher2003
approved these changes
Nov 27, 2025
raphael-goetz
approved these changes
Nov 27, 2025
Taucher2003
deleted the
160-change-version-to-a-string-instead-of-nested-object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #160