Skip to content

Fix some typos #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 1 commit into from
May 26, 2025
Merged

Fix some typos #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proto/shared/shared.data_type.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ message DataTypeIdentifier {

message GenericType {
DataTypeIdentifier data_type_identifier = 1;
repeated GenericMapper generic_mapper = 2;
repeated GenericMapper generic_mappers = 2;
}

message GenericMapper {
Expand Down
2 changes: 1 addition & 1 deletion proto/shared/shared.runtime_function.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ message FunctionGenericMapper {
}
// can only be a generic key
string target = 3;
optional string paramter_id = 4;
Copy link
Member

@Taucher2003 Taucher2003 May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RuntimeParameterDefinition we use runtime_name as identifier. Should this also match that and be called parameter_name?

optional string parameter_id = 4;
}

// Definition of a function used for execution
Expand Down