Skip to content

Conversation

@deauthe
Copy link
Contributor

@deauthe deauthe commented Oct 31, 2024

PR Fixes:

  • 1 Moved sidebar toggle closer to the navbar when scrolling
  • 2 Moved the breadCrumbComponent closer to the toggle when scrolling
  • 3 made the sidebar toggle more interactive -> added active:scale-90 transition-all duration-200 to its classNames.

Resolves #1533

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@devsargam
Copy link
Collaborator

Hey can you provide screenshots || screenrecordings of your change?

@deauthe
Copy link
Contributor Author

deauthe commented Nov 1, 2024

@devsargam sure!

before fix:

Screen.Recording.2024-11-01.at.2.39.34.PM.mov

After fix:

Screen.Recording.2024-11-01.at.2.44.23.PM.mov

@deauthe
Copy link
Contributor Author

deauthe commented Nov 1, 2024

a couple screenshots are also there in the #1534 issue for the actual and expected behaviour. The PR is supposed to address the same ;)

@devsargam devsargam merged commit cd00189 into code100x:main Dec 3, 2024
@devsargam
Copy link
Collaborator

Thank you!

hkirat pushed a commit that referenced this pull request Dec 5, 2024
* fixed breadcrumb spacing and sidebar toggle spacing

* removed visual aid colours for meself

* removed unnecessary changes

---------

Co-authored-by: deauthe <deauth@ANURAGs-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Sidebar Toggle and BreadcrumbComponent are too far apart from the Navbar to be sticky components

2 participants