Feat(371) - Disabled tracks after second page #394
Conversation
|
|
||
| let totalPages = Array.from({ length: track.problems.length }, (_, i) => i + 1); | ||
|
|
||
| localStorage.setItem('problemIndex', (problemIndex+1).toString()); |
There was a problem hiding this comment.
Why here?
Also why localStorage?
There was a problem hiding this comment.
Figured we could use problemIndex in other places so why not have it on hand in the parent component i.e BlogAppbar.
| const { resolvedTheme } = useTheme(); | ||
| const session = useSession(); | ||
| const isAuthenticated = session.status === 'authenticated' && session.data !== null; | ||
| const storedProblemIndex = localStorage.getItem('problemIndex'); |
There was a problem hiding this comment.
NotionRenderer isn't the only renderer we have
There is the coding renderer as well for example
This'll not work if the third page is a coding problem
There was a problem hiding this comment.
Hmm, I missed that scenario. Mb. I can try implementing similar functionality in LessionView.tsx and pass a variable (trackVisible) to the components(Blog, CodeRenderer, MCQRenderer). That would be a better way of doing this for now and if and when new components are added
|
Oh, great. LessonView implementation was exactly what I was going to go for.... I'll close my PR |
3 participants
PR Fixes:
Resolves #[371]
Checklist before requesting a review