Skip to content

ui changes#532

Closed
keshav-exe wants to merge 7 commits intocode100x:mainfrom
keshav-exe:ui-redesign
Closed

ui changes#532
keshav-exe wants to merge 7 commits intocode100x:mainfrom
keshav-exe:ui-redesign

Conversation

@keshav-exe
Copy link
Contributor

@keshav-exe keshav-exe commented Aug 15, 2024

PR Fixes:

  • 1 UI Upgrade
  • 2 Fixed Categorisation & Added "Cohort 2.0" & "Cohort 3.0"

Resolves #527 #530 #531 #535 #540 #549 #552

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Screenshot

@devsargam
Copy link
Contributor

LGTM, merging this after all other PR's are merged.

@keshav-exe
Copy link
Contributor Author

cool, thanks!

@nischal-shetty2
Copy link
Contributor

@keshav-exe could you share more screenshots on all the changes that you made, want to avoid making any changes involving them. btw ui looks sick

@keshav-exe
Copy link
Contributor Author

keshav-exe commented Aug 21, 2024

@devsargam @hkirat

What's Changed:

  • Dynamic Metadata for slides
  • Updated Notion Renderer (font, background, code block, copy buttons, and ofc animated)
  • fixed sizings from previous commit

localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-4
localhost_3000_auth_callbackUrl=http2F3A3000%2F
localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-2
localhost_3000_tracks_w5E6PT2t0IyOFM3bZxcM_aws-fe-2 (1)

@ItsFlash10
Copy link
Contributor

@devsargam @hkirat please check this for Notion Renderer redesign: #555

@keshav-exe
Copy link
Contributor Author

@devsargam fixed the issues we discussed.

@devsargam
Copy link
Contributor

Your design looks great sir. Only problem that I can see is getting this error when clicking the download button

image

@keshav-exe
Copy link
Contributor Author

looking into it

@keshav-exe
Copy link
Contributor Author

@devsargam fixed it please take a look

@hkirat
Copy link
Collaborator

hkirat commented Aug 26, 2024

This got a lot of merge conflicts
Tryingt o fix locally

@ItsFlash10
Copy link
Contributor

This got a lot of merge conflicts Tryingt o fix locally

I have resolved the conflicts in my PR maybe you can have a look #555

@ItsFlash10
Copy link
Contributor

ItsFlash10 commented Aug 26, 2024

This got a lot of merge conflicts Tryingt o fix locally

I have resolved the conflicts in my PR maybe you can have a look #555

Just saw you closed it, actually there were only 7odd file changes in my PR for Notion renderer changes but since #532 wasn't merge and I needed the new design I created the branch from @keshav-exe's ui-redesign branch so those files are there in the diff too :)

@hkirat hkirat mentioned this pull request Aug 26, 2024
@hkirat
Copy link
Collaborator

hkirat commented Aug 26, 2024

Moved changes to #572 , resolved conflicts there

@hkirat hkirat closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: The prev and next button should be at the bottom of the page

5 participants