-
Notifications
You must be signed in to change notification settings - Fork 13
Users fixes #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users fixes #274
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
| columns = ( | ||
| ["userUid", "status", "username", "orgUid"] | ||
| if format == OutputFormat.TABLE | ||
| else None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None means all columns
|
One unrelated thing I found while testing this change was we don't cleanly handle a bad orgUid. The service returns a 400 we could handle better: |
| assert "modificationDate" in result.output | ||
|
|
||
|
|
||
| def test_list_when_table_format_outputs_expected_columns( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test the columns we're filtering out aren't in the output?
Yeah @terimurie also point this out. I was thinking we should just add it to py42 and let it naturally propagate to the CLI |
list userscmds.