remove broken OutputFormat.echo_formatted_generated_output() #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
alanag13
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code42cli.output_formats.OutputFormatter.echo_formatted_generated_output()was initially added because theaudit-logscommand processed events for checkpointing as a generator, and the thought was that if an error occurred halfway through sending events to the terminal, we'd only have checkpointed the most recent one sent.However, the JSON, RAW-JSON, and CSV formatters weren't really designed with generators in mind, and thus they don't work with the current
echo_formatted_generated_output().I'm simply reverting to calling
list()on the generator prior to printing the output, so that formatting is no longer broken when using--use-checkpoint. I'd like to do some larger refactoring of output formats to handle generators down the line, but that work is too big for right now.