Bugfix/search arg validation #93
Conversation
| logger.print_and_log_error(u"You cannot use --advanced-query with additional search args.") | ||
| exit(1) | ||
| def exit_if_advanced_query_used_with_other_search_args(args, search_arg_enum): | ||
| invalid_args = ["begin", "end", "incremental"] + list(search_arg_enum) |
There was a problem hiding this comment.
If we moved --format out of search_shared.create_search_args() (seems like it could easily be useful elsewhere), we could have invalid_args be set tosearch_shared.create_search_args() - ["advanced_query"]. This would keep invalid_args in sync if we need to add more search args in the future.
There was a problem hiding this comment.
I just put all the incompatible args into their own function and used that to build the list.
|
@timabrmsn looks good, can you add tests that mock the result of |
No description provided.