move meeting checking back to the filter provider #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pjaudiomv
reviewed
Oct 13, 2025
pjaudiomv
approved these changes
Oct 13, 2025
Collaborator
pjaudiomv
left a comment
pjaudiomv
left a comment
There was a problem hiding this comment.
looks good to me, tested locally as well
joshreisner
deleted the
476-in-person-meeting-detail-page-maps-are-showing-all-locations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #476
in the previous PR #475 i had moved checking the current meeting to
Meeting.tsx, forgetting that we also need it inMap.tsxthis PR moves that checking back to where it was before, the FilterProvider
the only problem with the way it's implemented now is it's not reporting "meeting not found" when finding a stale meeting, just showing an empty page
i figure we can deal with that in a followup PR