Kehao ch10problems(2 of them) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added odd_sum and smooth_max that I created
Added odd_sum and smooth_max solutions that I created
Added odd_sum and smooth_max solutions that I created
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
phrdang
requested review from
a team and
AlveeraMunshi
and removed request for
a team
JJ27
approved these changes
Aug 4, 2020
JJ27
left a comment
JJ27
left a comment
There was a problem hiding this comment.
Nice job! Odd Sum and Smooth Max were both very creative problems, and they both give the correct answer for the 2D lists. I'll approve the merge but I think you need to address the bot's requested changes as well.
AlveeraMunshi
approved these changes
Aug 4, 2020
Member
AlveeraMunshi
left a comment
AlveeraMunshi
left a comment
There was a problem hiding this comment.
Problems are awesome; idk what's up with the flake8 stuff tho
phrdang
dismissed
github-actions[bot]’s stale review
It said no issues were detected, I think there's a bug
I'm merging to fix style issues detected by Lintly (flake8)
phrdang
dismissed
github-actions[bot]’s stale review
Black and flake8 have a conflict about splicing that isn't major. I'll just go with Black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ke Hao Chen
odd_sum
smooth_max
Repeat the Problem Title, Chapter #, and Section Name format for as many problems as you have.
Optional: Brief description of changes or any other notes you want to leave to the Curriculum Development team