Revert "Kehao ch10problems(2 of them)" #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
| @@ -1,12 +1,12 @@ | |||
| """ | |||
| Alternating | |||
| """ | |||
| 1 on each side, and 4 on the diagonals, for 8 in total. Each | ||
| pixel doesn't necessarily have 8 neighbors, though (think about why). | ||
| The neighbors of an image are all the pixels that surroun it, | ||
| 1 on each side, and 4 on the diagonals, for 8 in total. |
| were [20, 30, 40] and [10, 120, 30], the new pixel that would replace the | ||
| original one would be [15, 75, 35] | ||
| For example, if the neighbors of a pixel with value [1,2,3] | ||
| were [20,30,40] and [10,120,30], the new pixel that would replace the original one would be |
There was a problem hiding this comment.
E501: line too long (91 > 79 characters)
| 1 on each side, and 4 on the diagonals, for 8 in total. Each | ||
| pixel doesn't necessarily have 8 neighbors, though (think about why). | ||
| The neighbors of an image are all the pixels that surroun it, | ||
| 1 on each side, and 4 on the diagonals, for 8 in total. |
| were [20, 30, 40] and [10, 120, 30], the new pixel that would replace the | ||
| original one would be [15, 75, 35] | ||
| For example, if the neighbors of a pixel with value [1,2,3] | ||
| were [20,30,40] and [10,120,30], the new pixel that would replace the original one would be |
There was a problem hiding this comment.
E501: line too long (91 > 79 characters)
| i is associated with values | ||
| """ | ||
| """Iterating over the image here. i is a variable from 0 to the width of the image. | ||
| j is a variable that ranges from 0 to the height of the image. i is associated with |
There was a problem hiding this comment.
W191: indentation contains tabs
| i is associated with values | ||
| """ | ||
| """Iterating over the image here. i is a variable from 0 to the width of the image. | ||
| j is a variable that ranges from 0 to the height of the image. i is associated with |
There was a problem hiding this comment.
E101: indentation contains mixed spaces and tabs
| i is associated with values | ||
| """ | ||
| """Iterating over the image here. i is a variable from 0 to the width of the image. | ||
| j is a variable that ranges from 0 to the height of the image. i is associated with |
There was a problem hiding this comment.
E501: line too long (84 > 79 characters)
| """ | ||
| """Iterating over the image here. i is a variable from 0 to the width of the image. | ||
| j is a variable that ranges from 0 to the height of the image. i is associated with | ||
| values""" |
There was a problem hiding this comment.
W191: indentation contains tabs
| """ | ||
| """Iterating over the image here. i is a variable from 0 to the width of the image. | ||
| j is a variable that ranges from 0 to the height of the image. i is associated with | ||
| values""" |
There was a problem hiding this comment.
E101: indentation contains mixed spaces and tabs
Member
Author
|
You know what this is getting a bit confusing let's just deal with it on the side outside of GitHub :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39
I forgot that this includes changes from #41 so that got merged too even though I only wanted to merge the 2 problems @Citrus716 added for Ch. 10. (Next time Ke Hao please separate the code into different branches maybe? Or keep it all in one PR.)