This repository was archived by the owner on Dec 9, 2021. It is now read-only.
move maps out of the render method #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
n8rzz
reviewed
Sep 11, 2019
n8rzz
left a comment
n8rzz
left a comment
There was a problem hiding this comment.
Couple points on this:
- pay close attention to the
keystuff. React needs them to be unique and by passing a model name, uniqueness isn't guaranteed. I'd encourage adding the map index to the end of it. This also isn't ideal, but a little better for uniqueness. lodash.uniqueid is another possible option - for these new methods, are you actually rendering or are you building? The Ranfeltian school suggests the structure:
_buildThingWereBuildingJsx
As usual, these are nitpicks bordering on bike-sheding, so take what you'd like and go from there 😉
| const { episodeTables } = this.props; | ||
|
|
||
| return episodeTables.map((model) => ( | ||
| <div key={model.title}> |
There was a problem hiding this comment.
what happens if there is another model with a same title? these keys need to be unique
Owner
Author
There was a problem hiding this comment.
In this case I know that titles will be unique because I create them in the selector.
There was a problem hiding this comment.
How would react and/or an implementor know that? See also:
- https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md
- https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md (this is actually a counter-argument to my index suggestion)
Owner
Author
|
@n8rzz I made smaller component but add the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.