Skip to content

Conversation

@peterkos
Copy link
Contributor

@peterkos peterkos commented Dec 11, 2020

Fixes #1027, #1002, #1023

  • Schedule events changed
  • Carousel aligned on mobile
  • Mobile hacky version for now (no viewport set)
  • Hero hacky version for mobile hacky version; no wire
  • Tweaked containers to vaguely work on mobile

Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
@peterkos peterkos self-assigned this Dec 11, 2020
@peterkos peterkos added the BH7 label Dec 11, 2020
@peterkos peterkos marked this pull request as ready for review December 11, 2020 22:04
Signed-off-by: Peter Kos <pkos91@icloud.com>
@peterkos peterkos requested a review from cbaudouinjr December 11, 2020 22:05
@peterkos peterkos linked an issue Dec 11, 2020 that may be closed by this pull request
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
@peterkos peterkos linked an issue Dec 11, 2020 that may be closed by this pull request
@peterkos peterkos merged commit 4030319 into develop Dec 11, 2020
@peterkos peterkos deleted the bh-1027 branch December 11, 2020 22:32
peterkos added a commit that referenced this pull request Dec 11, 2020
This reverts commit 4030319.

Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos added a commit that referenced this pull request Dec 11, 2020
This reverts commit fb44ff8.

Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos added a commit that referenced this pull request Dec 11, 2020
* Various bugfixes before social push (#1028)

* Attempt at hero bug fixes

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fixed schedule items

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fix clipping on temp mobile version

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Tweak leadership

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile “hack” for hero works

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Comment issue link viewport

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Messy mobile styling for hero

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile FAQ

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Revert "Various bugfixes before social push (#1028)"

This reverts commit 4030319.

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Revert "Revert "Various bugfixes before social push (#1028)""

This reverts commit fb44ff8.

Signed-off-by: Peter Kos <pkos91@icloud.com>

Co-authored-by: ww2497 <ww2497@rit.edu>
peterkos added a commit that referenced this pull request Aug 4, 2021
* Attempt at hero bug fixes

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fixed schedule items

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fix clipping on temp mobile version

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Tweak leadership

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile “hack” for hero works

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Comment issue link viewport

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Messy mobile styling for hero

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile FAQ

Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos added a commit that referenced this pull request Aug 4, 2021
This reverts commit dda00f8.

Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos added a commit that referenced this pull request Aug 4, 2021
This reverts commit 8332ffe.

Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos added a commit that referenced this pull request Aug 4, 2021
* Various bugfixes before social push (#1028)

* Attempt at hero bug fixes

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fixed schedule items

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Fix clipping on temp mobile version

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Tweak leadership

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile “hack” for hero works

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Comment issue link viewport

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Messy mobile styling for hero

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Mobile FAQ

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Revert "Various bugfixes before social push (#1028)"

This reverts commit dda00f8.

Signed-off-by: Peter Kos <pkos91@icloud.com>

* Revert "Revert "Various bugfixes before social push (#1028)""

This reverts commit 8332ffe.

Signed-off-by: Peter Kos <pkos91@icloud.com>

Co-authored-by: ww2497 <ww2497@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hero scaling bug, FAQ outline fix, Schedule adjustments, Mobile viewport Mobile styling Align carousel on mobile

3 participants