Start of full-site conversion #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterkos
requested changes
Nov 1, 2020
Contributor
There was a problem hiding this comment.
Thanks for your patience on my slow review!
Lots of good stuff in here, the scaling is fantastic!
There's a couple things I'll bring up at design sync, namely
navbar bolding / colors on hover"Brickhack 7" line spacing / position on smaller screensMLH banner "major league hacking" text is super super small on mobile, although I'm not sure there's much we can do if their banner is just Made like thatPossibly making the site a bit more breathable on the sides on Large screens; on 27" everything looks quite big (I know we talked about making it 100% width for now but I'll play around w/ how it looks with a bit of space on each side)
But I think we can make a separate PR for all that stuff; most of my comments in this review are about the code itself!
Update: See #967 for next steps on design
peterkos
approved these changes
Nov 1, 2020
|
|
||
| <ul className="mobile-hide"> | ||
| <img id="logo" alt="BrickHack Logo"/> | ||
| <a href="#hero"><li>GENERAL</li></a> |
Contributor
There was a problem hiding this comment.
Sorry just noticed this -- <a> should go inside <li>
Member
Author
There was a problem hiding this comment.
The padding is part of the <li>. I want the padding to be hoverable/clickable. Taking another look, I think I accidentally used margin for the horizontal spacing which I'll need to fix.
peterkos
pushed a commit
that referenced
this pull request
Aug 4, 2021
Start of full-site conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.