General section #972
Merged
General section #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A few large changes need to be made; to make reviewing this easier on Saturday's meeting I'll go over the changes! |
peterkos
requested changes
Nov 28, 2020
Contributor
peterkos
left a comment
peterkos
left a comment
There was a problem hiding this comment.
These are just some general comments; great start so far! We'll go over more in Sat's meeting but these should get you started on some basic changes.
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Still needs fix on large + small #responsive #web2.0 #netscape Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos
requested changes
Dec 1, 2020
Contributor
|
There's also bug on smaller screens where general text gets clipped as the height of the section is not high enough to accommodate for it |
Signed-off-by: Peter Kos <pkos91@icloud.com> # Conflicts: # src/index.scss
Signed-off-by: Peter Kos <pkos91@icloud.com> # Conflicts: # package-lock.json
peterkos
previously approved these changes
Dec 3, 2020
Contributor
|
Still needs arrow and hover effect on buttons but we'll add that later |
Signed-off-by: Peter Kos <pkos91@icloud.com>
peterkos
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.