From-scratch rewrite of site #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Strange logo size MLH badge doesn’t overflow properly Added scaffolding for rest of site Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
Current solution: manually copy them over in the build script. Alternatively, we can also just never remove the build directory and only update it, and keep the static files in there. However it will make it slightly harder to access/edit those files, given that they’ll be scattered around with the other output from parcel. parcel-bundler/parcel#2099 Signed-off-by: Peter Kos <pkos91@icloud.com>
Now everything in `resources` will be copied into `build` on build! Signed-off-by: Peter Kos <pkos91@icloud.com>
Contributor
Author
|
Also includes the start of some WIP design changes:
|
cbaudouinjr
previously approved these changes
Dec 9, 2020
Member
cbaudouinjr
left a comment
cbaudouinjr
left a comment
There was a problem hiding this comment.
I have personally hand-reviewed all 982 files of this pull request. 
Signed-off-by: Peter Kos <pkos91@icloud.com>
cbaudouinjr
approved these changes
Dec 9, 2020
Member
cbaudouinjr
left a comment
cbaudouinjr
left a comment
There was a problem hiding this comment.
I've spent a few hours reviewing the EOF change. While I do have some disagreements about the implementation I say we to production for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Differences
Why?
Old version of site would be too complicated to refactor, and instead is faster to just rewrite. This consists of most of the implementation for desktop of the nav, hero, general, and leadership sections of the site.
Current implementation