Replaces Highcharts with Chart.js#1003
Conversation
WalkthroughThe project transitioned from using the Highcharts library to Chart.js for chart rendering. This change involved removing Highcharts from the dependency list, updating JavaScript asset dependencies, and modifying initialization scripts to accommodate Chart.js, aiming to improve maintainability, performance, and reduce potential licensing costs. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
Gemfile.lockis excluded by:!**/*.lock
Files selected for processing (4)
- Gemfile (1 hunks)
- app/assets/javascripts/application.assets.js (1 hunks)
- app/assets/javascripts/manage/application.js (1 hunks)
- app/assets/javascripts/manage/lib/setupChartJs.js (1 hunks)
Files skipped from review due to trivial changes (1)
- Gemfile
Additional comments: 2
app/assets/javascripts/manage/application.js (1)
- 18-18: The call to
setupChartJscorrectly reflects the transition to Chart.js. Ensure thatsetupChartJsis properly adapted to Chart.js's API and configuration requirements.app/assets/javascripts/application.assets.js (1)
- 17-17: The inclusion of
Chart.bundlein the asset pipeline correctly aligns with the transition to Chart.js. Ensure that this bundle version supports all the features needed for your charting requirements.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- app/assets/javascripts/manage/application.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/assets/javascripts/manage/application.js
Closes #1002
Summary by CodeRabbit