Skip to content
This repository was archived by the owner on Mar 1, 2026. It is now read-only.

fix: Validate asset config values are URLs#178

Merged
dquach217 merged 5 commits intomasterfrom
issue_164
Aug 25, 2019
Merged

fix: Validate asset config values are URLs#178
dquach217 merged 5 commits intomasterfrom
issue_164

Conversation

@dquach217
Copy link
Copy Markdown
Contributor

Fixes #164

@dquach217 dquach217 requested a review from sman591 August 16, 2019 20:05
Comment thread test/controllers/manage/configs_controller_test.rb Outdated
Comment thread test/controllers/manage/configs_controller_test.rb Outdated
Comment thread test/controllers/manage/configs_controller_test.rb Outdated
Comment thread app/controllers/manage/configs_controller.rb Outdated
Comment thread app/controllers/manage/configs_controller.rb Outdated
@dquach217
Copy link
Copy Markdown
Contributor Author

@sman591 not sure how to go about reducing the code complexity

Copy link
Copy Markdown
Member

@sman591 sman591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One small suggestion then good to go

Comment thread app/controllers/manage/configs_controller.rb Outdated
Comment thread test/controllers/manage/configs_controller_test.rb
@sman591 sman591 changed the title bugfix: validate the asset to contain a url fix: Validate the asset to contain a url Aug 18, 2019
dquach217 and others added 2 commits August 17, 2019 22:09
@dquach217
Copy link
Copy Markdown
Contributor Author

@sman591 Change has been made and added a bit more

Comment thread test/controllers/manage/configs_controller_test.rb Outdated
Co-Authored-By: Stuart Olivera <stuart@stuartolivera.com>
@sman591 sman591 changed the title fix: Validate the asset to contain a url fix: Validate asset config values are URLs Aug 25, 2019
@dquach217 dquach217 merged commit b2021b3 into master Aug 25, 2019
@sman591 sman591 deleted the issue_164 branch August 25, 2019 00:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate asset configs to use https:// addresses

3 participants