Skip to content

Conversation

@sman591
Copy link
Member

@sman591 sman591 commented Apr 10, 2020

Updates to the latest version of several Ruby gems.

Tested by spinning up the app locally and clicking around both the account + admin pages; everything looks good

context "#file_basename" do
should "use mix of type, date, and time" do
# Set consistent local time
Timecop.freeze(DateTime.new(2020, 01, 15, 4, 5, 6, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/DateTime: Prefer Date or Time over DateTime.
Style/NumericLiteralPrefix: Use 0o for octal literals.

@sman591 sman591 requested a review from cbaudouinjr April 11, 2020 20:13
Copy link
Member

@cbaudouinjr cbaudouinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@cbaudouinjr cbaudouinjr merged commit 13ab0a3 into master Apr 26, 2020
@cbaudouinjr cbaudouinjr deleted the stuart/updates branch April 26, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants