This repository was archived by the owner on Aug 8, 2019. It is now read-only.
Conversation
cristianbgp
force-pushed
the
feature-clubs-by-location
branch
from
397df7b to
3e9fffd
Compare
condef5
reviewed
Jul 17, 2019
| <div css={styleSelectsContainer}> | ||
| <Select | ||
| onChange={handleChangeLocation} | ||
| defaultValue="" |
There was a problem hiding this comment.
Could you assign a more significant name instead of defaultValue ?
Contributor
There was a problem hiding this comment.
That's the default value for the select tag
condef5
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #17
It uses Open Cage Data to transform adresses to coordinates.
It adds
geolibto the pacakge json to calculate distances between coordinates.It sorts all the clubs by their location.