Skip to content
This repository was archived by the owner on Aug 8, 2019. It is now read-only.

Commit 0de96e6

Browse files
committed
Add user role on project creation, user rate on edit and minor bug
1 parent fb00372 commit 0de96e6

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

rails-time-track/app/controllers/api/users_controller.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ def show
2020
end
2121

2222
def update
23+
@user.update(user_params)
2324
if @user.update(user_params)
25+
@user.update(rate: @user.rate*100)
2426
render json: @user, status: :ok
2527
else
2628
render_errors(@user.errors.full_messages.join("\n"), :unprocessable_entity)

rails-time-track/app/models/user.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def reset_token_expired?
3838
def availableTimeRange(startDate, endDate)
3939
workingDaysRange = (startDate..endDate).filter {|d| (1..5).include?(d.wday) }
4040
listProjectAssigned = self.project_members.includes(:project)
41-
return Array.new(workingDaysRange.length, 100) if projects.size == 0
41+
return Array.new(workingDaysRange.length, 100) if listProjectAssigned.size == 0
4242

4343
listTimeByProject = listProjectAssigned.map do |project|
4444
projectTimeRange = (project.project.start_date..project.project.end_date).filter {|d| (1..5).include?(d.wday) }

rails-time-track/app/serializers/user_available_time_serializer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
class UserAvailableTimeSerializer < ActiveModel::Serializer
2-
attributes :id, :name, :rate, :availableTime, :isChosen
2+
attributes :id, :name, :rate, :availableTime, :isChosen, :role
33

44
def availableTime
55
params = @instance_options[:option_name]

rails-time-track/db/seeds.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,23 @@
33
#Create users
44

55
owner = User.create(
6-
name: "Diego Owner",
6+
name: "Diego",
77
email: "diegotc86@gmail.com",
88
password: "123456",
99
role: "Owner",
1010
rate: 6200
1111
)
1212

1313
manager1 = User.create(
14-
name: "Brayan Manager",
14+
name: "Brayan",
1515
email: "linzeur@hotmail.com",
1616
password: "123456",
1717
role: "Manager",
1818
rate: 4300
1919
)
2020

2121
manager2 = User.create(
22-
name: "Frank Manager",
22+
name: "Frank",
2323
email: "manager2@mail.com",
2424
password: "123456",
2525
role: "Manager",
@@ -28,31 +28,31 @@
2828
)
2929

3030
analyst1 = User.create(
31-
name: "Jonathan Analyst",
31+
name: "Jonathan",
3232
email: "jcmendozar10@gmail.com",
3333
password: "123456",
3434
role: "Analyst",
3535
rate: 1200
3636
)
3737

3838
analyst2 = User.create(
39-
name: "Lian Analyst",
39+
name: "Lian",
4040
email: "analyst2@mail.com",
4141
password: "123456",
4242
role: "Analyst",
4343
rate: 1100
4444
)
4545

4646
analyst3 = User.create(
47-
name: "Carlos Analyst",
47+
name: "Carlos",
4848
email: "analyst3@mail.com",
4949
password: "123456",
5050
role: "Analyst",
5151
rate: 1150
5252
)
5353

5454
analyst4 = User.create(
55-
name: "Carmen Analyst",
55+
name: "Carmen",
5656
email: "analyst4@mail.com",
5757
password: "123456",
5858
role: "Analyst",
@@ -341,7 +341,7 @@
341341
DailyLog.create(
342342
project_member: member,
343343
date: day.to_s,
344-
amount: (member.estimated_cost / duration * rand(0.75..1.75)).to_i
344+
amount: (member.estimated_cost / duration * rand(0..1.85)).to_i
345345
)
346346
end
347347
}
@@ -360,7 +360,7 @@
360360
DailyLog.create(
361361
project_member: member,
362362
date: day.to_s,
363-
amount: (member.estimated_cost / duration * rand(0.75..1.75)).to_i
363+
amount: (member.estimated_cost / duration * rand(0..1.85)).to_i
364364
)
365365
end
366366
}

react-time-track/src/components/add-member-project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ function AddMemberProject({ listMember, addMemberFn, closeModalFn }) {
246246
>
247247
{listMember.map(value => (
248248
<option value={value.id} key={value.id}>
249-
{value.name}
249+
{`${value.name} (${value.role})`}
250250
</option>
251251
))}
252252
</select>

react-time-track/src/views/edit-user.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ function EditUser({ user_id }) {
1919
});
2020

2121
React.useEffect(() => {
22-
getUser(user_id).then(data => setUser(data));
22+
getUser(user_id).then(data => {
23+
data.rate /= 100;
24+
setUser(data);
25+
});
2326
}, []);
2427

2528
function handleSubmit(e) {

0 commit comments

Comments
 (0)