Fix #41 and prepare release 1.3.1 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we need to handle parameters that doesn't pass through to api we need a parameter for that in parameter specs. We decided to use `api_invisible` for that purpose. The method `_auto_resolve_entities` will sort out these parameters/keys from `desired_entity`.
As a subnet can exists in more than one section at all we also need to provide section for an address. This parameter is `api_invisible`, because the phpIPAM api doesn't know anything about this parameter. This will fix codeaffen#41.
lush
approved these changes
Nov 26, 2020
FlatKey
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.