Skip to content

Conversation

@xyzwilliamxyz
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Migration of version codes and dependencies from buildSrc to Version Catalog.

💡 Motivation and Context

Help with dependency versions being recognized by other tools and plugins

💚 How did you test it?

Tested on Android sample.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

🔮 Next steps

Later on, upgrading Gradle to version 8.0+ is desirable, as it'll fix the false positive on top-level gradle scripts: issue. Also, migrating plugins that currently were not present at buildSrc.

@xyzwilliamxyz xyzwilliamxyz requested a review from kikoso as a code owner June 7, 2023 19:15
@xyzwilliamxyz xyzwilliamxyz self-assigned this Jun 8, 2023
@xyzwilliamxyz xyzwilliamxyz merged commit 52ae54c into main Jun 9, 2023
@xyzwilliamxyz xyzwilliamxyz deleted the chore/add-version-catalog branch June 9, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants