Add CSS animation hooks (is-entering / is-leaving) to BLX Modal#10
Merged
liampmccabe merged 2 commits intomainfrom Mar 3, 2026
Merged
Add CSS animation hooks (is-entering / is-leaving) to BLX Modal#10liampmccabe merged 2 commits intomainfrom
liampmccabe merged 2 commits intomainfrom
Conversation
Co-authored-by: liampmccabe <3018957+liampmccabe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add animation customizations to modal component
Add CSS animation hooks (is-entering / is-leaving) to BLX Modal
Mar 3, 2026
Copilot stopped work on behalf of
liampmccabe due to an error
March 3, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal had no lifecycle class hooks, making it impossible to animate open/close transitions for the backdrop or dialog without overriding internals.
Changes
packages/modal/index.js(v1.1.0)[blx-el="modal-popup"]:is-entering— present during the open animation; removed onanimationend/transitionendis-leaving— present during the close animation; all teardown (ARIA, focus restore, DOM reposition) deferred until animation completeswaitForAnimation(el, callback)helper:getComputedStyleforanimation-duration/transition-duration; parses comma-separated multi-value lists and uses the longestanimationend+transitionendwith acalledguard, plus asetTimeoutfallback for interrupted/display-toggled casesis-enteringcleanly before addingis-leavingpackages/modal/README.md@keyframesexample animating backdrop and dialog independently, CSS transition example, and a note on enter-direction behaviour.Usage
No CSS defined → instant open/close as before.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.