Enable description field in workshop creation #783 #1115
Conversation
|
@turger thank you for this contribution Taru 🎉 There is one codeclimate issue that needs fixing up, once done I'm happy for it to be merged. |
matyikriszta
left a comment
matyikriszta
left a comment
There was a problem hiding this comment.
@turger thanks for the PR, I've left you a few comments.
turger
force-pushed
the
description-field-to-workshops
branch
3 times, most recently
from
59d044e to
3345cb9
Compare
notapatch
left a comment
notapatch
left a comment
There was a problem hiding this comment.
Two minor changes .. looks good.
turger
force-pushed
the
description-field-to-workshops
branch
from
3345cb9 to
786a2dc
Compare
|
Looks good. Same deal, sometime during the week and probably later in the day it will be reviewed. Question: have you rebased it recently? I can't tell (there must be a way of knowing online but I don't know ho) It's a good idea to keep it rebased while waiting otherwise you wake up with the message "I want to merge .... but can you rebase first" instead of the much more enjoyable (for you and the maintainer!) "merged!" |
|
@notapatch yup I rebased this branch today 👍 |
matyikriszta
left a comment
matyikriszta
left a comment
There was a problem hiding this comment.
@turger thanks for your hard work on this and thanks for addressing all of our feedback 🎉
4 participants
Added description field to workshops.