-
-
Notifications
You must be signed in to change notification settings - Fork 198
Add copy about featuring job in newsletter #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8fc02d4 to
5b12603
Compare
despo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback
config/locales/es.yml
Outdated
| salary: The job pays an appropriate salary | ||
| short: "It's short and to the point" | ||
| approval_info: "*Once submitted, a job will be visible once it has been reviewed and approved." | ||
| newsletter: "For an additional <strong>£250</strong> you can list the job in our newsletter. Our newsletter goes out every other month to an audience of 10000 students and coaches. To learn more about including your job in our newsletter send us an email at <a href='mailto:hello@codebar.io'>hello@codebar.io</a>." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tweak this text to remove some repetition to something like:
newsletter: "For an additional £250 you can have your job listing featured in our bimonthly newsletter and made available to an audience of over 10000 students and coaches. To find out more send us an email at hello@codebar.io."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@despo so Ben and I had a discussion about this and bimonthly is very ambiguous. Is it twice a month or every other month? Happy to update the copy but I don't think we should use that word specifically. Basically I wanted to be clear that it's every other month and not twice a month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even know why I used it, I think I had the PR's description in my head- as I feel the same way about it, to me it means twice a month lol. Let me rephrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@despo haha, yeah, I realized I used it in the PR description while arguing against it here 🤦♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is frequency important enough to mention here? Is it not more important when the next newsletter is due, as someone wanting to list a job eg at the beginning of the month is not likely to be interested to be featured in a newsletter going out in three weeks. So, can we just drop the mention?
newsletter: "For an additional £250 you can have your job listing featured in our newsletter and made available to an audience of over 10000 students and coaches. To find out more details and when our next newsletter is due send us an email at hello@codebar.io."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@despo yep, sounds good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@despo updated the copy if you want to take another look
5b12603 to
c4bfed5
Compare
despo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
This PR adds a paragraph to the job#new page about featuring the job in our bimonthly (once every two months) newsletter. @KimberleyCook please feel free to suggest copy changes. Additionally, let me know if you think we should add this to any other pages?
Status
Ready for Review
Related Trello ticket
https://trello.com/c/qIkc57WW
Screenshots