Add "how you found us" summary to the chapter admin page#2466
Open
mikej wants to merge 6 commits intocodebar:masterfrom
Open
Add "how you found us" summary to the chapter admin page#2466mikej wants to merge 6 commits intocodebar:masterfrom
mikej wants to merge 6 commits intocodebar:masterfrom
Conversation
mikej
force-pushed
the
show-chapter-how-you-found-us-stats
branch
from
7c93d89 to
0869e8c
Compare
this is a preparatory step before adding a sidebar card that will show a summary of how members found this chapter (based on the responses to the "How did you find out about us" question that's asked during signup). before adding that card we want to ensure all existing sidebar content inside a card.
for large: cards are shown in a sidebar for medium: cards are shown next to each other, above the main column for small: cards are shown vertically one on top of the other so we need some horizontal spacing between cards for medium and some vertical spacing between cards for small.
reduce space between sidebar and main column on the chapter admin page offsetting by a column was introducing quite a lot of horizontal space between the two columns so we can reduce this and create more space for the content.
add a card to the sidebar on the chapter admin page that shows a summary of the responses to the "How did you find out about us" question that members are asked during signup.
mikej
force-pushed
the
show-chapter-how-you-found-us-stats
branch
from
0869e8c to
a58f9cb
Compare
Contributor
|
One tiny issue - could you fixup that last commit? I think it's a variable introduced in this PR, so it should be simple enough to squash. Otherwise this is awesome. Have you thought about a release note to drop in the organisers chat? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a card to the sidebar on the chapter admin page that shows a summary of the responses to the "How did you find out about us" question that members are asked during signup.