Update the default method when rendering a 404#2519
Merged
olleolleolle merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
This was a very strange bug. We found that users visiting `events/introduction-to-git-1/invitation/hello@codebar.io` (we don't know how this url was generated) caused the application to crash. We fixed it with 6c83d92, but it bothered me that the 404 page was not our standard one. It turns out that rails interprets a dot as a format separator. That meant the url was being parsed as `events/introduction-to-git-1/invitation/hello@codebar.`, with a format of 'io'. In our previous application_controller.rb file, that was caught by the line ` format.all { head :not_found }`. The result of this should be a nice splash page whenever there's a 404, including where a URL is malformed. Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
olleolleolle
approved these changes
Mar 11, 2026
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
This is an improvement!
(If we ever need to support a failing JSON serving some JSON rather than some HTML in the error case, this is where we'll change our code. No need to support that, yet!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a very strange bug. We found that users visiting
events/introduction-to-git-1/invitation/hello@codebar.io(we don't know how this url was generated) caused the application to crash. We fixed it with 6c83d92, but it bothered me that the 404 page was not our standard one.It turns out that rails interprets a dot as a format separator. That meant the url was being parsed as
events/introduction-to-git-1/invitation/hello@codebar., with a format of 'io'. In our previous application_controller.rb file, that was caught by the lineformat.all { head :not_found }.The result of this should be a nice splash page whenever there's a 404, including where a URL is malformed.