Fix: Use sponsor capacity for in-person workshop attendance checks#2611
Merged
mroderick merged 1 commit intocodebar:masterfrom May 6, 2026
Merged
Conversation
PR codebar#2609 changed WorkshopPresenter to use model.student_spaces and model.coach_spaces for capacity checks, but this broke in-person workshops that rely on sponsor capacity. Most in-person workshops have student_spaces=0 and coach_spaces=0 in the database, with actual capacity coming from the sponsor/venue. This fix changes event_student_spaces? and event_coach_spaces? to use the presenter methods student_spaces and coach_spaces, which delegate to the sponsor for in-person workshops. - In-person workshops: use venue.seats and venue.coach_spots - Virtual workshops: use model.student_spaces and model.coach_spaces Fixes: Workshops incorrectly showing as full when sponsor has capacity
KimberleyCook
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug introduced in #2609 where in-person workshops incorrectly appear as full even when the sponsor has available capacity.
Problem
PR #2609 changed
WorkshopPresenter#event_student_spaces?andevent_coach_spaces?to usemodel.student_spacesandmodel.coach_spaces(database columns). However, most in-person workshops in production have these values set to0, with actual capacity coming from the sponsor/venue:This caused workshops like Barcelona #3747 to show "The workshop is full" when there were actually 20 student spots and 20 coach spots available.
Solution
Changed the capacity check methods to use the presenter methods
student_spacesandcoach_spacesinstead of the database columns directly:This ensures:
venue.seatsandvenue.coach_spots(sponsor capacity)model.student_spacesandmodel.coach_spaces(viaVirtualWorkshopPresenterdelegation)Testing
Affected Workflows
This fixes the issue where:
As reported for Barcelona and Berlin workshops.