feat: make async email delivery the default for all workshop invitations#2630
Merged
mroderick merged 3 commits intoMay 29, 2026
Merged
Conversation
Replace conditional async/sync email delivery with async everywhere. All workshop invitations, attendance reminders, and waiting list notifications now use deliver_later regardless of chapter. This is a follow-up to PR codebar#2592 which added the feature flag but left it unset in production, causing London's bulk invitation jobs to continue timing out at 540s on Heroku.
The conditional async email feature flag is no longer needed now that all chapters use async delivery by default.
The feature flag is no longer needed. All workshop invitations now use async delivery by default. Remove the environment variable from production config when deploying.
Collaborator
Author
|
The async delivery was tested in the Brighton chapter in I don't know when the |
olleolleolle
approved these changes
May 29, 2026
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Easier, more streamlined!
till
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see the continued occurrence of this bug in https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/692#detail
Summary
Follow-up to #2592 which introduced a feature flag for async email delivery, but left it unset in production. This meant London (and all other chapters) continued sending workshop invitations synchronously inside a single DelayedJob, causing timeouts at 540s on Heroku.
Changes
deliver_later— removes the per-chapter conditionalAsyncEmailConcern— no longer neededASYNC_EMAIL_CHAPTER_IDSenv var — clean up unused configurationWhy
Affected Workshop Identified
From the production database, the most recent timeout occurred on:
37701)2026-06-03 18:30:001302026-05-28 12:34:17 UTCrunning(stuck — never completed)2,290Three additional London workshops also have invitation logs stuck in
runningstatus from prior timeouts (workshop IDs 3759, 3750, and 3743).Commits
feat: default workshop invitations to async email deliveryrefactor: remove AsyncEmailConcernchore: remove ASYNC_EMAIL_CHAPTER_IDS env var and configEach commit is green with matching test changes.
Deployment note
Remove
ASYNC_EMAIL_CHAPTER_IDSfrom Heroku config vars after deploy.