fix: include invited coaches who never RSVPed in feedback dropdown#2686
Closed
mroderick wants to merge 1 commit into
Closed
fix: include invited coaches who never RSVPed in feedback dropdown#2686mroderick wants to merge 1 commit into
mroderick wants to merge 1 commit into
Conversation
Closes #2633 The feedback form was only showing coaches with attending=true or attended=true. This excluded new coaches who were invited but never RSVPed (attending=nil) and then showed up to coach. Since these coaches are invisible in the admin attendance UI (which only shows attending=true), organisers often could not mark them as attended, leaving students unable to submit feedback for them. Now the feedback dropdown also includes coaches with attending=nil, so students can always select a coach who was invited to the workshop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2633
Problem
The feedback form dropdown only showed coaches with
attending=trueorattended=true. This excluded new coaches who were invited to a workshop but never RSVPed (attending=nil) and then showed up anyway.Because these coaches are invisible in the admin attendance UI (which only renders
@attending_coaches, i.e.attending=true), organisers often could not mark them as attended. Students were then unable to submit feedback when their coach was missing from the required dropdown.Fix
FeedbackController#set_coachesnow also includes coaches withattending=nil, so any invited coach can be selected for feedback.What changed
app/controllers/feedback_controller.rb: broadened the coach query fromaccepted_or_attendedtoattending IS NULL OR attending = true OR attended = truespec/features/member_feedback_spec.rb: added a feature test covering the walk-in coach scenario (Issue coach name missing in the feedback form #2633)Test evidence