Skip to content

Conversation

@khamiltonuk
Copy link
Contributor

Homepage copy moved to locale file config/locales/en.yml so they can be translated at a later date

New

Emailing codebar interested to become a host mailto now has a pre-populated subject line

bugfix

Noticed a broken translation reference in code of conduct mailto pre-populated subject line

@coveralls
Copy link

coveralls commented Sep 6, 2018

Coverage Status

Coverage remained the same at 89.373% when pulling c7e1b8e on khamiltonuk:feature/811-Add-Homepage-strings-to-translations-locales into 419dfef on codebar:master.

Copy link
Contributor

@matyikriszta matyikriszta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @khamiltonuk, sorry for being pedantic but explanation is spelled incorrectly across the PR. Can you update all instances of it to the correct spelling?

@khamiltonuk
Copy link
Contributor Author

@matyikriszta Not pedantic at all, good spot, and thank you.

Copy link
Contributor

@matyikriszta matyikriszta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khamiltonuk looks good, thanks for updating 👍

@matyikriszta matyikriszta merged commit 4565afc into codebar:master Sep 18, 2018
@matyikriszta
Copy link
Contributor

matyikriszta commented Sep 18, 2018

Fixes #811

MarckK pushed a commit to MarckK/planner that referenced this pull request Dec 14, 2018
…age-strings-to-translations-locales

Feature/811 add homepage strings to translations locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants