Skip to content

Conversation

@maria-logh
Copy link
Contributor

Added Transitions to the HTML & CSS Lesson 5 Tutorial

Copy link
Contributor

@KimberleyCook KimberleyCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is really great @maria-logh thank you, a few little changes needed then I'll merge. Thank you again :)





Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all these added extra lines please?

transition-delay: 1s;
}```


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of this section is not correct.

screen shot 2016-12-05 at 10 19 04

transition-duration: 4s;
}```

Create another one:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we amend this line saying that we are adding in the transition delay please?

}
```

Add the **property** which we are chaning and its new value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property already exists in the tutorial, could we say that we are going to go back and amend it rather than add it please?

@KimberleyCook
Copy link
Contributor

Hey @maria-logh I'd love to merge this PR in once the little amends are done. If you need any help just send me an email kimberleycook91@gmail.com :)

@KimberleyCook KimberleyCook changed the base branch from gh-pages to css-transition-add February 4, 2017 15:06
@KimberleyCook KimberleyCook merged commit 62c987c into codebar:css-transition-add Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants