Skip to content

amend to tutorial homepage#338

Merged
KimberleyCook merged 2 commits intogh-pagesfrom
adjust-homepage
Feb 10, 2017
Merged

amend to tutorial homepage#338
KimberleyCook merged 2 commits intogh-pagesfrom
adjust-homepage

Conversation

@KimberleyCook
Copy link
Copy Markdown
Contributor

Added the codebar logo and adjusted the order of the tutorials so it is now all code related followed by the git/version control ones.

Copy link
Copy Markdown
Member

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. I've got one small comment and another small change request. Other than that, looks great!

Comment thread index.html Outdated

<p class="view"><a href="https://github.com/codebar/tutorials">View on GitHub <small>codebar/tutorials</small></a></p>
<header>
<img src="./assets/codebar_logo.png" class="logo" alt="codebar logo">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just src="assets/codebar_logo.png"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I've spent too much time doing React 👍

Comment thread index.html Outdated
<p class="view"><a href="https://github.com/codebar/tutorials">View on GitHub <small>codebar/tutorials</small></a></p>
<header>
<img src="./assets/codebar_logo.png" class="logo" alt="codebar logo">
<p>codebar tutorials</p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an h1.

@KimberleyCook KimberleyCook merged commit f6ce9d6 into gh-pages Feb 10, 2017
@richardwestenra richardwestenra deleted the adjust-homepage branch February 10, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants