Replace use of 'join' function with 'implode' #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a student googles 'join' to learn more they'll just see that it's an alias of implode, and then have to read about implode. https://www.php.net/manual/en/function.join.php Better to just use implode so there's one less step.
|
FYI I wrote my own PHP tutorial a couple of years ago. I don't know how much interest your students have in PHP though. https://a-moderately-short-php-tutorial.com/ I can also recommend Jon Duckett's book, which is came out recently and covers modern PHP. |
|
Thanks @bdsl |
|
That was quick! Thanks @KimberleyCook . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a student googles 'join' to learn more they'll just see that it's an alias of implode, and then have to read about implode.
https://www.php.net/manual/en/function.join.php
Better to just use implode so there's one less step.