Skip to content

V0.4.1/tweakking git story teller#12

Merged
gimlichael merged 18 commits intomainfrom
v0.4.1/tweakking-git-story-teller
May 3, 2026
Merged

V0.4.1/tweakking git story teller#12
gimlichael merged 18 commits intomainfrom
v0.4.1/tweakking-git-story-teller

Conversation

@gimlichael
Copy link
Copy Markdown
Member

This pull request introduces a minor release (v0.4.1) focused on significant enhancements to the git-story-teller skill, with improvements to grounding rules, context navigation, subagent delegation, evidence-based language, and deterministic output artifacts. The documentation has been updated to reflect these new features, stricter contracts, and expanded sync requirements for skill management.

Key changes:

git-story-teller Skill Enhancements

  • Enforces complete-read grounding: Agents must fully read target and overview contexts before writing, using chunked files and indexes to handle output caps, and cannot skip evidence due to prompt/token limits. [1] [2] [3]
  • Adds public API summaries and engineering signal maps to context output, helping agents focus on consumer-facing types, validation guards, and test evidence in their stories. [1] [2] [3]
  • Supports subagent-friendly delegation: When multiple independent target contexts exist, subagents can process them in isolation, reducing prompt contention while maintaining strict grounding. [1] [2]
  • Implements conservative test ownership mapping: Only assigns a test project if there's a dedicated, unambiguous match, avoiding accidental assignment of downstream tests. [1] [2]
  • Introduces chunked context navigation: Emits *.context.index.md and ordered chunk files to enable robust, complete reading even when tools cap single-file output. [1] [2] [3]

Evidence-based Language and Grounding

  • Forbids unmeasured behavior claims (e.g., "most common mistake") unless supported by explicit evidence in the context; mandates conditional language when evidence is lacking. [1] [2]
  • Clarifies that context indexes are navigation aids only and cannot be used as evidence for story claims.

Documentation and Workflow Updates

  • Updates SKILL.md, README.md, and CHANGELOG.md to document new output artifacts, workflow contracts, public API orientation, engineering signals, chunked navigation, and stricter grounding requirements. [1] [2] [3] [4] [5] [6]
  • Expands the AGENTS.md skill sync section to include Gemini Antigravity install location, requiring sync across four locations for repo-managed skills. [1] [2]

Release Management

  • Bumps version to 0.4.1 and adds a detailed changelog entry summarizing all new features, changes, and fixes. [1] [2]

These updates make git-story-teller more robust, deterministic, and evidence-driven, while improving agent workflow and output reliability.

aicia-bot added 14 commits May 3, 2026 21:59
…avity guidance

- Document 4-way skill sync: repo, Claude install, global agents, Gemini Antigravity
- Update git-story-teller description with subagent and complete-read grounding patterns
- Clarify package-facing overview and phase-scoped reading in Why section
- Rename 'TARGET STORIES TO READ FIRST' to 'REQUIRED COMPLETED TARGET STORY SOURCES'
- Require agent to read completed target stories before overview
- Clarify that target stories are primary source, overview context supplementary
- Emphasize manifest-ordered reading and result file dependencies
- Add grounding rules for overview synthesis from target results
- Refine eval 1-3 expectations: require completed target files as primary source for overview
- Add eval 7: test complete-read grounding with capped file output
- Add eval 8: test subagent-per-target delegation with independent contexts
- Enforce that overview.context.md alone is never sufficient for Index.md
- Ensure subagent summaries do not replace completed target result files
…w workflow

- Add sourceResults list to manifest overview phase entry
- Require agent to read all completed target files before Index.md synthesis
- Clarify in instructions that target stories are primary source, context file supplementary
- Update manifest generation to list target result file paths as required sources
- Enforce blocking: overview synthesis requires target results, not context alone
- Clarify that unmeasured frequency claims require explicit context evidence
- Add guidance on separating structural evidence from behavioral frequency
- Expand checklists to flag 'most common', 'often', 'frequently', 'typical', 'popular'
- Provide regex patterns for validating grounded prose in result files
- Update README grounded prose rule with concrete examples
- Test that aggregate package guidance is grounded in dependency structure
- Verify no 'most common', 'developers often', 'frequently' claims without evidence
- Require neutral language like 'if you only need X, aggregate package adds Y'
- Enforce conditional, pragmatic recommendations over inferred behavior
- Document full output artifacts including API summaries, engineering signals, chunked context
- Expand Why section with public-API-first orientation, signal maps, and complete-read grounding
- Highlight improved context navigation for agents with index and chunk files
- Add complete-read grounding rules with mandatory full-inspection requirements
- Document subagent strategy for independent target contexts with strict grounding
- Add evidence-based language validation patterns to prevent frequency claims without proof
- Expand overview phase rules to require reading all target result files as primary sources
- Add regex patterns for detecting unmeasured frequency, popularity, and behavior claims
- Refine evals 1-3 to require completed target files as primary source for overview
- Add eval 7 testing complete-read grounding with capped file output
- Add eval 8 testing subagent-per-target delegation with independent contexts
- Add eval 9 for grounded tradeoff guidance without unmeasured frequency claims
- Enforce that overview synthesis requires target results, not context alone
- Add public API summary generation for consumer-facing types and inheritance chains
- Implement engineering signal map highlighting validation guards, factories, and test evidence
- Add low-signal filtering to remove GlobalSuppressions.cs from context
- Generate *.context.index.md and ordered *.context.chunks/*.md files for robust navigation
- Support chunked context reading when tools cap single-file output
- Refine manifest generation with sourceResults for overview phase dependencies
- Document complete-read grounding rules and mandatory target-story sourcing
- Highlight optional subagent delegation for independent target contexts
- Explain evidence-based language validation to prevent unmeasured claims
- Document public API summaries and engineering signal maps
- Add chunked context navigation for robust file reading
- Update compare links for v0.4.1 release
- Update v0.4.1 CHANGELOG entry with conservative test mapping feature
- Add conservative test ownership line to README 'Why git-story-teller?' section
- Clarify that runner prefers dedicated test projects over downstream package tests
- Document test project filtering rules in SKILL.md Fallback notes
- Add eval 11 testing conservative test ownership with shared base packages
- Validate that runner prefers dedicated test projects over downstream tests
- Ensure Test path is left undiscovered when only ambiguous matches exist
- Prefer dedicated test projects matching target package name plus test suffix
- Only use direct project references when dedicated test project unavailable
- Leave Test path undiscovered when multiple downstream tests share base package prefix
- Add TestProjectMatch record for ordered evaluation of test ownership
- Strip known suffixes (Tests, Test, UnitTests, FunctionalTests, IntegrationTests) for matching
- Sort candidates by ownership priority and name for deterministic selection
@gimlichael gimlichael self-assigned this May 3, 2026
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Strengthen git-story-teller with complete-read grounding and chunked context navigation

✨ Enhancement 🧪 Tests

Grey Divider

Walkthroughs

Description
• Implements complete-read grounding with chunked context navigation
  - Emits *.context.index.md and ordered *.context.chunks/*.md files for robust reading when tools
  cap output
  - Enforces mandatory full-context reads before writing stories
• Adds public API summaries and engineering signal maps to context
  - Generates deterministic navigation aids highlighting consumer-facing types, lifecycle contracts,
  validation guards, and test evidence
• Implements conservative test ownership mapping
  - Prefers dedicated test projects with matching names over downstream package tests
• Enforces evidence-based language validation
  - Prevents unmeasured frequency claims like "most common" without explicit source evidence
  - Requires conditional phrasing for tradeoff guidance
• Supports subagent-friendly delegation for independent target contexts
• Updates skill sync guidance to include Gemini Antigravity install location
Diagram
flowchart LR
  A["Context Generation"] --> B["Full Context File"]
  A --> C["Context Index"]
  A --> D["Ordered Chunks"]
  B --> E["Agent Reading"]
  C --> E
  D --> E
  E --> F["Public API Summary"]
  E --> G["Engineering Signals"]
  F --> H["Target Story"]
  G --> H
  H --> I["Completed Target Results"]
  I --> J["Overview Synthesis"]
  J --> K["Result/Index.md"]
Loading

Grey Divider

File Changes

1. skills/git-story-teller/scripts/story.cs ✨ Enhancement +649/-26

Implement chunked context navigation and API/signal generation

• Adds MaxContextChunkBodyBytes constant (36 KB) for chunking large contexts
• Implements WriteContextArtifactsAsync to generate full context, index, and ordered chunk files
• Adds SplitContextIntoChunks and SplitOversizedLine for deterministic context splitting
• Implements BuildContextIndex and BuildChunkFile to create navigation aids
• Adds DiscoverPublicApiTypes and BuildPublicApiSummary to generate API navigation tables
• Implements BuildEngineeringSignals with regex-based signal extraction for exceptions, lifecycle,
 hosting, and tests
• Refactors FindTestDirectory to use conservative test ownership mapping with TestProjectMatch
 record
• Adds IsOwnTestProjectName and StripKnownTestSuffix for dedicated test project matching
• Implements FilterLowSignalPackedContent to remove GlobalSuppressions.cs from packed context
• Updates manifest generation to include contextIndex and contextChunks entries
• Enhances instructions with complete-read contract, chunk navigation guidance, and evidence-based
 language rules
• Adds regex patterns PublicTypeRegex and PublicMemberRegex for API discovery

skills/git-story-teller/scripts/story.cs


2. AGENTS.md 📝 Documentation +7/-5

Add Gemini Antigravity to four-way skill sync guidance

• Expands skill sync guidance from three locations to four
• Adds ~/.gemini/antigravity/skills/<name>/ as required sync location
• Updates copy commands to include Gemini Antigravity path
• Clarifies that all four locations must stay synchronized

AGENTS.md


3. CHANGELOG.md 📝 Documentation +28/-1

Document v0.4.1 release with new features

• Adds v0.4.1 release entry with comprehensive feature list
• Documents complete-read grounding, subagent delegation, evidence-based language, public API
 summaries, engineering signals, conservative test mapping, and chunked navigation
• Lists all added features, changed behaviors, and fixes

CHANGELOG.md


View more (3)
4. README.md 📝 Documentation +12/-4

Update README with complete-read and signal generation features

• Updates git-story-teller description to mention public API summaries, engineering signals,
 conservative test paths, context indexes, and chunk files
• Expands "Why git-story-teller?" section with new capabilities
• Adds bullet points for public API first, engineering signal maps, conservative test ownership,
 low-signal filtering, chunked navigation, complete-read grounding, subagent-friendly targets,
 story-sourced overview, and phase-scoped reading
• Clarifies grounded prose rules to forbid unmeasured frequency claims

README.md


5. skills/git-story-teller/SKILL.md 📝 Documentation +86/-13

Refine skill contract for complete-read grounding and subagents

• Updates description to mention public API summaries, engineering signals, and chunked context
 indexes
• Adds critical rules for complete-read grounding and subagent delegation
• Clarifies that context indexes are navigation aids, not evidence
• Adds guidance on using generated API summaries and engineering signals as inspection prompts
• Expands workflow steps with complete-read requirements and chunk navigation
• Adds optional subagent strategy section for independent target contexts
• Enhances overview step with requirement to read completed target result files as primary source
• Adds grounding rules against unmeasured frequency claims
• Expands verification checklist with context index/chunk validation and frequency-claim detection
• Adds complete-read rules section replacing context budget rules
• Adds good output characteristics for subagent coordination and complete reads
• Expands anti-patterns with subagent misuse, capped context handling, and frequency-claim mistakes

skills/git-story-teller/SKILL.md


6. skills/git-story-teller/evals/evals.json 🧪 Tests +74/-5

Add evals for complete-read, subagents, and evidence-based language

• Updates eval 1 to require context index and chunk usage when full context is capped
• Updates eval 2 to recognize contextIndex and contextChunks manifest entries
• Updates eval 3 to require reading completed target result files as primary overview source
• Adds eval 7 testing complete-read grounding with capped file output and chunk navigation
• Adds eval 8 testing subagent-per-target delegation with independent contexts
• Adds eval 9 testing evidence-based tradeoff guidance without frequency claims
• Adds eval 10 testing public API summaries, engineering signals, and internal-detail usage
• Adds eval 11 testing conservative test ownership mapping with downstream test projects

skills/git-story-teller/evals/evals.json


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Looking for bugs?

Check back in a few minutes. An AI review agent is analyzing this pull request.

Grey Divider

Qodo Logo

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 3, 2026

Greptile Summary

This PR delivers v0.4.1 of the git-story-teller skill, adding chunked context navigation (*.context.index.md + ordered chunk files), public API summary and engineering signal map generation, conservative test project ownership matching, low-signal file filtering (GlobalSuppressions.cs), subagent delegation patterns, and stricter evidence-based grounding rules. Documentation across AGENTS.md, README.md, CHANGELOG.md, and SKILL.md is updated accordingly, and the story.cs runner gains the corresponding C# implementation for all new artifacts.

The previous review's compiled-regex concern is fully resolved — PublicTypeExpression and PublicMemberExpression are now static readonly fields.

Confidence Score: 5/5

Safe to merge; only a single P2 eval-consistency finding with no runtime impact.

No P0 or P1 issues found. The C# script additions are well-structured, the compiled-regex regression from the previous review is fixed with static readonly fields, and the chunking/manifest logic is internally consistent. The sole finding is a contradictory first expectation in eval 11 that won't affect runtime behaviour.

skills/git-story-teller/evals/evals.json — eval 11 first expectation contradicts its own prompt scenario.

Important Files Changed

Filename Overview
skills/git-story-teller/scripts/story.cs Large addition of public API summary generation, engineering signal map, context chunking/indexing, conservative test ownership logic, low-signal file filtering, and updated manifest serialization; static compiled Regex fields replace per-call construction (addresses previous review comment); logic is sound.
skills/git-story-teller/SKILL.md Substantial expansion of grounding rules, subagent delegation strategy, evidence-based language requirements, and chunked context navigation contract; well-structured and internally consistent.
skills/git-story-teller/evals/evals.json Adds evals 7-11 and updates evals 1-3; eval 11 has a contradictory first expectation that says the dedicated test project exists when the prompt says it does not.
AGENTS.md Adds Gemini Antigravity as a 4th sync location throughout; corrects heading from "both" to "local installs"; fully addresses previous P1/P2 review comments.
CHANGELOG.md Adds 0.4.1 changelog entry dated 2026-05-04 (one day in the future relative to current date 2026-05-03); version links updated correctly.
README.md Documentation updated to cover Gemini Antigravity skill folder and expanded git-story-teller feature bullet list; no issues found.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
skills/git-story-teller/evals/evals.json:488-497
**Eval 11 prompt and first expectation contradict each other**

The `prompt` field explicitly states "there is no dedicated `Codebelt.Extensions.Xunit.Tests` project", but the first expectation says "Recognizes `Codebelt.Extensions.Xunit.Tests` as the dedicated test project for `Codebelt.Extensions.Xunit`". An agent running this eval in a grader will see conflicting signals: the scenario says the project doesn't exist, yet the expectation rewards recognising it as the dedicated test project. The remaining expectations (leave `Test path` undiscovered, don't use `Hosting.AspNetCore.Tests`) are consistent with the prompt — only the first expectation is out of place. Consider revising it to something like "Recognises `<PackageName>.Tests` as the expected dedicated-test-project naming convention" so it tests naming-pattern knowledge without implying the file exists in the scenario.

Reviews (2): Last reviewed commit: "⚡ Optimize regex compilation in story.cs" | Re-trigger Greptile

Comment thread skills/git-story-teller/scripts/story.cs
aicia-bot added 4 commits May 4, 2026 00:37
- Add Fixed section bullets documenting exact suffix matching for test discovery
- Clarify eval 11 expectations for dedicated test project patterns
- Prevent false positives from partial test-suffix overlaps in project names
- Replace suffix-stripping logic with exact suffix matching on target + suffix
- Check if normalized project name equals target plus known test suffix pattern
- Prevent false positives like confusing 'Xunit.Tests' with 'Xunit' + 'UnitTests'
- Support multiple suffix patterns: Tests, Test, UnitTests, UnitTest, etc.
- Update AGENTS.md Local Install Sync to include Gemini Antigravity folder
- Clarify that changes mirror to repo, Claude, agents, and Gemini installs
- Add Gemini Antigravity to README skill folder table
- Update skill installation tips to support multiple personal skill folders
- Move PublicTypeExpression and PublicMemberExpression to static readonly fields
- Compile regexes once at class initialization instead of recreating per method call
- Improve performance of public API extraction and engineering signal detection
@gimlichael gimlichael merged commit d384ffb into main May 3, 2026
1 check passed
@gimlichael gimlichael deleted the v0.4.1/tweakking-git-story-teller branch May 3, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants