V9.0.0/support for async lifetime #19
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| using System; | ||
| using Codebelt.Extensions.Xunit.Hosting.AspNetCore.Assets; | ||
| using Microsoft.AspNetCore.Builder; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Codebelt.Extensions.Xunit.Hosting.AspNetCore | ||
| { | ||
| public class AspNetCoreHostFixtureTest : Test | ||
| { | ||
| public AspNetCoreHostFixtureTest(ITestOutputHelper output) : base(output) | ||
| { | ||
| } | ||
|
Comment on lines
+9
to
+13
There was a problem hiding this comment. Add tests for async lifecycle methods. Given that this PR introduces async lifecycle support (InitializeAsync, DisposeAsync), the test class should include tests that verify these new async capabilities of AspNetCoreHostFixture. Consider adding the following test cases:
Would you like me to help generate these async test implementations? |
||
|
|
||
| [Fact] | ||
| public void ConfigureHost_NullHostTest_ThrowsArgumentNullException() | ||
| { | ||
| // Arrange | ||
| var fixture = new AspNetCoreHostFixture(); | ||
|
|
||
| // Act & Assert | ||
| Assert.Throws<ArgumentNullException>(() => fixture.ConfigureHost(null)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ConfigureHost_InvalidHostTestType_ThrowsArgumentOutOfRangeException() | ||
| { | ||
| // Arrange | ||
| var fixture = new AspNetCoreHostFixture(); | ||
| var invalidHostTest = new InvalidHostTest<AspNetCoreHostFixture>(fixture); | ||
|
|
||
| // Act & Assert | ||
| Assert.Throws<ArgumentOutOfRangeException>(() => fixture.ConfigureHost(invalidHostTest)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ConfigureApplicationCallback_SetAndGet_ReturnsCorrectValue() | ||
| { | ||
| // Arrange | ||
| var fixture = new AspNetCoreHostFixture(); | ||
| Action<IApplicationBuilder> callback = app => { }; | ||
|
|
||
| // Act | ||
| fixture.ConfigureApplicationCallback = callback; | ||
|
|
||
| // Assert | ||
| Assert.Equal(callback, fixture.ConfigureApplicationCallback); | ||
| } | ||
|
Comment on lines
+36
to
+48
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance test to verify callback execution. The current test only verifies the property storage. Consider enhancing it to verify that the stored callback is actually executed when the application is configured. [Fact]
public void ConfigureApplicationCallback_SetAndGet_ReturnsCorrectValue()
{
// Arrange
var fixture = new AspNetCoreHostFixture();
- Action<IApplicationBuilder> callback = app => { };
+ var callbackExecuted = false;
+ Action<IApplicationBuilder> callback = app => { callbackExecuted = true; };
// Act
fixture.ConfigureApplicationCallback = callback;
+ fixture.ConfigureHost(new ValidHostTest(fixture));
// Assert
Assert.Equal(callback, fixture.ConfigureApplicationCallback);
+ Assert.True(callbackExecuted, "Callback should have been executed during host configuration");
}
|
||
|
|
||
| [Fact] | ||
| public void ConfigureHost_ValidHostTest_ConfiguresHostCorrectly() | ||
| { | ||
| // Arrange | ||
| var fixture = new AspNetCoreHostFixture(); | ||
| var hostTest = new ValidHostTest(fixture); | ||
|
|
||
| // Act | ||
| fixture.ConfigureHost(hostTest); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(fixture.Host); | ||
| Assert.NotNull(fixture.Application); | ||
| } | ||
|
Comment on lines
+50
to
+63
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance host configuration validation. The current test only verifies that Host and Application are non-null. Consider adding more specific assertions about the expected configuration state. [Fact]
public void ConfigureHost_ValidHostTest_ConfiguresHostCorrectly()
{
// Arrange
var fixture = new AspNetCoreHostFixture();
var hostTest = new ValidHostTest(fixture);
+ var expectedServiceType = typeof(ITestService);
// Act
fixture.ConfigureHost(hostTest);
// Assert
Assert.NotNull(fixture.Host);
Assert.NotNull(fixture.Application);
+ // Verify expected services are registered
+ var serviceProvider = fixture.Host.Services;
+ var service = serviceProvider.GetService(expectedServiceType);
+ Assert.NotNull(service);
+ // Verify expected middleware is configured
+ // Add more specific assertions based on ValidHostTest configuration
}
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,11 @@ | ||||||||||||||||||||
| using Xunit; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| namespace Codebelt.Extensions.Xunit.Hosting.AspNetCore.Assets | ||||||||||||||||||||
| { | ||||||||||||||||||||
| public class InvalidHostTest<T> : Test, IClassFixture<T> where T : class, IHostFixture | ||||||||||||||||||||
| { | ||||||||||||||||||||
| public InvalidHostTest(T hostFixture) | ||||||||||||||||||||
| { | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
+7
to
+9
There was a problem hiding this comment. Store the hostFixture parameter for test usage. The constructor accepts a hostFixture parameter but doesn't store it, which might be needed for test scenarios. public InvalidHostTest(T hostFixture)
{
+ HostFixture = hostFixture;
}
+protected T HostFixture { get; }📝 Committable suggestion
Suggested change
|
||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using Microsoft.AspNetCore.Builder; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
|
|
||
| namespace Codebelt.Extensions.Xunit.Hosting.AspNetCore.Assets | ||
| { | ||
| public class ValidHostTest : AspNetCoreHostTest<AspNetCoreHostFixture> | ||
| { | ||
| public ValidHostTest(AspNetCoreHostFixture hostFixture) : base(hostFixture) | ||
| { | ||
| } | ||
|
|
||
| public override void ConfigureServices(IServiceCollection services) | ||
| { | ||
|
|
||
| } | ||
|
|
||
| public override void ConfigureApplication(IApplicationBuilder app) | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document additional changes mentioned in PR objectives.
The release notes should also include:
IHostFixtureinterface (newDisposeAsyncmethod)HostFixtureclass (new async lifecycle methods)xunit.extensibility.corepackage dependencyApply this diff to add the missing changes:
📝 Committable suggestion