fix code-generation command and regenerate models #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added notes on contrib.yml workflow behavior and its limitations during release preparations.
…open-telemetry#4799) * Initial commit * Make changes * Make changes to approach * Make more changes * windows is failing but not sure why * Fix bug on windows.. * Commit changes * Update opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * Respond to comment * remove duplicate filter from propagate false logger * clarify comment * make changes * Apply suggestion from @xrmx Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> * Update opentelemetry-sdk/tests/logs/test_export.py * merge --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…SOURCE_DETECTORS` to `*` (open-telemetry#4819) * Allow loading all resource detectors by setting `OTEL_EXPERIMENTAL_RESOURCE_DETECTORS` to `all` * Add changelog * Use `*` instead of `all`
* Siwtch recursion suppression to use ContextVar * Add changelog fix typecheck * Update changelog * minor change * Fix typecheck
…emetry#4869) Fixes open-telemetry#4868 The Prometheus exporter was generating duplicate HELP and TYPE declarations for metrics with varying label sets, violating the Prometheus format specification and causing rejection by Prometheus Pushgateway with the error: "second HELP line for metric name." Changes: - Modified metric family ID to exclude label keys, using only metric name, description, and unit - Implemented two-pass processing: first pass collects all unique label keys across data points, second pass builds label values with empty strings for missing labels - Ensured single metric family per metric type with consolidated label keys - Updated test expectations to verify single HELP/TYPE declaration with proper empty string handling for missing labels This aligns with the Go implementation approach and ensures compatibility with Prometheus Pushgateway and other strict validators. Co-authored-by: Aaron Abbott <aaronabbott@google.com>
* feat(http): add error handling for exporting * feat(http_exporter): allow to run retry loop on connection errors * feat(http): change error types that are caught * refactor(http): introduce variables to unify logging * feat(http_exporter): only retry on connection error * test(http_exporter): add test case for connection errors while exporting * refactor(http): simplify if statements * docs(changelog): add changes * fix(http_exporter): use correct class after rebase * docs(changelog): update changelog * refactor(http_exporter): add empty space in logs * docs(tests): remove comments * refactor(tests): simplify tests * Update CHANGELOG.md * Update exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/__init__.py * Apply suggestions from code review --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
* test-util: allow filtering metrics by scope * Apply suggestions from code review --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
) * Fix: Reinitialize gRPC channel on UNAVAILABLE error (Fixes open-telemetry#4517) * fix: address PR review comments for gRPC reconnection * refactor(exporter): simplify reconnection logic and address review comments - Remove aggressive gRPC keepalive and retry settings to rely on defaults. - Fix compression precedence logic to correctly handle NoCompression (0). - Refactor channel initialization to be stateless (remove _channel_reconnection_enabled).- Update documentation to refer to 'OTLP-compatible receiver' * fix: remove extra blank line in docstring * fix(exporter): address typecheck errors and add changelog entry --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
MikeGoldsmith
changed the title
… into codeboten/generate-config-model-from-schema
10 tasks
codeboten
merged commit 43f2c09
into
codeboten:codeboten/generate-config-model-from-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tox command to set the correct dependencies and add an allowed_external. Running
tox -e generate-config-from-jsonschemais now successful and regenerates the models file atopentelemetry-sdk/src/opentelemetry/sdk/_configuration/models.py.I also added the
use-union-operator = truesuggested by @xrmx in the upstream PR, and then regenerated the models file.Changes: