Merged
Conversation
…and enhanced Field metadata
…ope in HttpExceptionFilter
…o param/query decorators
…notifications usage
…s; update metadata
…s.json from commit
…cription logging; shrink metadata generation
…w jobs Previously, the service would stop processing all jobs after encountering the first existing job, preventing new jobs from being added to the database. Now it skips existing jobs but continues processing the rest.
…l new jobs Previously, the service would stop processing all jobs after encountering the first existing job, preventing new jobs from being added to the database. Now it skips existing jobs but continues processing the rest.
…ameters Added @type(() => Number) decorators to skip, first, and last pagination parameters to automatically convert query string parameters to integers before validation, fixing 'must be an integer' validation errors.
…ob controller Removed manual parseInt() logic for skip and first parameters since @type() decorators in PaginationArgs now handle automatic transformation. This eliminates duplicate parameter handling and potential conflicts.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes job fetching and pagination issues in a NestJS application. The changes implement a comprehensive job management system with external data source integration, pagination utilities, and WebSocket functionality.
- Implements job fetching from Reddit and Web3Career APIs with notification system
- Adds comprehensive pagination utilities with cursor and offset-based pagination support
- Introduces WebSocket gateway for real-time communication and Redis-based pub/sub functionality
Reviewed Changes
Copilot reviewed 161 out of 216 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| test/app.e2e-spec.ts | Reformats test to single line |
| src/main.ts | Major application bootstrap overhaul with OpenTelemetry, middleware, and configuration |
| src/users/* | Complete user management system with authentication, validation, and GraphQL resolvers |
| src/jobs/* | Job management system with external API integration and comprehensive CRUD operations |
| src/common/* | Shared utilities including pagination, database, Redis, logging, and validation helpers |
| src/notifications/* | Push notification system supporting both web push and FCM |
| src/auth/* | Authentication system with JWT, Google OAuth, and Redis-based session management |
| src/wss/* | WebSocket gateway implementation with Redis adapter support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.