Fix redundant navigation in permissions tab press handler

[Copilot]

When already on the permissions index, the tab press listener was calling e.preventDefault() + router.replace('/(tabs)/permissions') — navigating to the same route unnecessarily, risking flickering.

Changes

• app/(tabs)/_layout.tsx: Removed isOnPermissionsIndex from the tabPress condition; the handler now only intercepts navigation when on a permissions sub-page
• Removed the now-unused isOnPermissionsIndex variable

Before:

const isOnPermissionsSubPage = pathname.startsWith('/permissions/') && pathname !== '/permissions';
const isOnPermissionsIndex = pathname === '/permissions' || pathname === '/(tabs)/permissions';

if (isOnPermissionsSubPage || isOnPermissionsIndex) {
    e.preventDefault();
    router.replace('/(tabs)/permissions');
}

After:

const isOnPermissionsSubPage = pathname.startsWith('/permissions/') && pathname !== '/permissions';

if (isOnPermissionsSubPage) {
    e.preventDefault();
    router.replace('/(tabs)/permissions');
}

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR fixes a redundant navigation issue in the permissions tab press handler. Previously, when a user was already on the permissions index page and tapped the permissions tab, the handler would unnecessarily navigate to the same route, potentially causing flickering or unwanted behavior.

Changes:

• Removed the isOnPermissionsIndex check from the tab press handler condition
• Deleted the unused isOnPermissionsIndex variable

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.