Conversation
There was a problem hiding this comment.
Pull request overview
Updates the self-hosted Android build workflow to use an ANDROID_HOME path with Sdk capitalization, aligning with common Android Studio defaults on case-sensitive filesystems.
Changes:
- Change
ANDROID_HOMEfrom.../Android/sdkto.../Android/Sdkin the SDK verification step. - Change
ANDROID_HOMEfrom.../Android/sdkto.../Android/Sdkin the Gradle build step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Force a fixed SDK location for the runner | ||
| ANDROID_HOME="/home/digitalnomad91/Android/sdk" | ||
| ANDROID_HOME="/home/digitalnomad91/Android/Sdk" | ||
|
|
||
| # Export for subsequent steps | ||
| echo "ANDROID_HOME=$ANDROID_HOME" >> $GITHUB_ENV |
There was a problem hiding this comment.
ANDROID_HOME is hard-coded to a specific user home path. This makes the workflow brittle on any self-hosted runner where the account/home directory differs (and it also changes behavior depending on whether the SDK dir is Sdk vs sdk). Prefer deriving from $HOME (e.g., $HOME/Android/Sdk) and/or using an existing ANDROID_SDK_ROOT/ANDROID_HOME if already set, with a fallback check for both common casings before failing.
| - name: '🏗️ Build Release APK with Gradle' | ||
| run: | | ||
| export ANDROID_HOME="/home/digitalnomad91/Android/sdk" | ||
| export ANDROID_HOME="/home/digitalnomad91/Android/Sdk" |
There was a problem hiding this comment.
This step re-exports ANDROID_HOME with another hard-coded absolute path, which duplicates the earlier configuration and can silently drift if one location is changed later. Since ANDROID_HOME is already written to $GITHUB_ENV in the prior step, use that value here (or remove this line) to keep the workflow single-sourced.
| export ANDROID_HOME="/home/digitalnomad91/Android/Sdk" |
No description provided.