Socket.IO support #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
There was a problem hiding this comment.
Backported this to Froyo, was missing this function.
…e already connected.
|
+1 |
Missing semi-colon in example code.
Update README.md
In the SocketIOClient, `onConnect()` never called `mHandler.onConnect()`
If a message from the socket.io server is emitted with no arguments, it now is properly received
Fixed crash on a no-argument message
Fixed a bug with incorrect URL when base URI with trailing slash is used.
Fire onConnect event when connection established
Fix logic error from the javascript port.
Client will now send a heartbeat back to the server when it receives one, so the connection won't time out. Removed unreachable catch block in cleanup() method, and changed WebSocketClient.Handler() to a Listener() to match the recent change to to the WebSocketClient interface. Changed print statements to use Log, to be consistent with the rest of the package.
Added heartbeat replies, fixed two bugs, and added logging.
Create an SSL socket for https connections.
Added support for Message and JSONMessage
Updated README
Fixed double firing of onConnect().
I converted my application from AutobahnAndroid to android-websockets to take advantage of ssl support. android-websockets did not have a isConnected method, which is used in my application, so I implemented one.
add isConnected method and remove incorrect annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not support message or JSON Message. Not sure why that is necessary, as node's socket IO only really recommends using the event message. The other two seem deprecated.