feat: add card reading progress bottom sheet#243
Merged
codebutler merged 4 commits intomasterfrom Feb 22, 2026
Merged
Conversation
Add a ModalBottomSheet to HomeScreen that shows NFC reading progress with determinate/indeterminate progress bars. Thread onProgress callbacks through all card readers (Classic, Ultralight, FeliCa, DESFire, CEPAS, Vicinity, ISO7816) and platform scanners (Android, iOS, Web, Desktop). On iOS, progress updates the native Core NFC alert message instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add null checks for window._fbUsb.device before transferOut/transferIn calls to prevent JsException when device is disconnected mid-scan - Add console logging (println + printStackTrace) for scan errors and card processing errors in HomeViewModel so they appear in DevTools Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the packaged desktop app runs without libusb installed, PN533Device.openAll() throws UnsatisfiedLinkError which was uncaught and crashed silently (no UI feedback). Now catch it gracefully and fall back to PC/SC-only scanning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The ClassCastException (UnauthorizedClassicSector → DataClassicSector) was only shown in the UI error dialog but never printed to console, making it invisible in DevTools. Add println + printStackTrace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
codebutler
pushed a commit
that referenced
this pull request
Feb 22, 2026
Resolve conflicts between key recovery wiring and card reading progress bottom sheet feature (#243). Key changes in resolution: - ClassicCardReader.readCard uses master's (Int, Int) onProgress signature - Key recovery progress messages use println instead of onProgress - All scanners wire both key recovery (our branch) and progress (master) - WebUsbPN533Transport device-disconnection checks use error field Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadingProgressdata class andreadingProgressStateFlow toCardScannerinterfaceonProgresscallbacks through all card readers (Classic, Ultralight, FeliCa, DESFire, CEPAS, Vicinity, ISO7816) and all platform scanners (Android, iOS, Web, Desktop)ModalBottomSheetto HomeScreen showing NFC reading status with determinate/indeterminate progress barTest plan
🤖 Generated with Claude Code