fix: Aplanar estructura de categorías en respuestas del wardrobe #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include category id in select query and flatten categories structure
from { category: { id, name } } to { id, name } for proper API response.
Closes #39
josueJouvin
approved these changes
Dec 18, 2025
…o-esta-bien-construido
- Implement comprehensive tests for CombinationsService, covering methods such as generateCombinations, saveCombination, getCombinations, updateStatusCombination, getCombinationById, addItemsToCombination, updateStatusItemFromCombination, and more. - Add unit tests for WardrobeService, including create, getClothes, getClothesById, update, updateStatus, addCategory, deactivateCategory, uploadFiles, deactivateImage, and activateImage methods. - Mock dependencies like PrismaService, MultimediaService, and Logger for isolated testing. - Ensure proper error handling and validation in tests, including scenarios for existing items, inactive statuses, and database errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
Este PR resuelve el issue #39 - "El array de categories no contiene id y no está bien construido"
Problema
Cuando se recibían los datos del wardrobe, el array de
categoriestenía una estructura anidada innecesaria:{ "categories": [ { "category": { "name": "Tops" } }, { "category": { "name": "Casual" } } ] }Esto requería hacer "drilling" de
categories.categoryen el frontend para acceder a los datos.Solución
Se implementó la transformación de datos para aplanar la estructura, devolviendo ahora:
{ "categories": [ { "id": "uuid-1", "name": "Tops" }, { "id": "uuid-2", "name": "Casual" } ] }Cambios realizados
wardrobe.service.ts:getClothes(): Agregadoidal select de categorías y transformación para aplanar la estructuragetClothesById(): Agregada transformación para aplanar la estructura de categoríasBeneficios
idde cada categoría para operaciones del frontendcategories.categoryCloses #39