Using Dynamic Configs Cuts WaitForTimeout by 1000 Each Time

[vkoves]

What are you trying to achieve?

We are looking to use dynamic configs to be able to test a second site within our larger suite, which has a different base URL but shares a lot of common UI elements.

What do you get instead?

Every time we use .config on a Feature, it causes the config to get revalidated and the waitForTimeout property's value appears to get divided by 1000 every time, making it so that each feature gets a smaller and smaller timeout, going from 10 sec to 0.01 sec, to 0.00001 sec, and so on.

Here's some sample output from one of our tests:

-- FAILURES:

1) Admin - FEATURE 1 NAME
  SCENARIO NAME
  element (.reveal-modal-bg) still visible after 0.01 sec

2) Admin - FEATURE 1 NAME
  SCENARIO NAME
  element (.reveal-modal-bg) still visible after 0.01 sec

3) Admin - FEATURE 2 NAME
  SCENARIO NAME
  element ({css: .fixed-width-message}) still not visible after 0.00001 sec

...

6) Admin - FEATURE 3 NAME
  SCENARIO NAME
  element ({css: .cdk-global-overlay-wrapper form}) still not visible after 1e-8 sec

...

9) Admin - FEATURE 4 NAME
  SCENARIO NAME
  element ({css: communities-list table > tbody > tr:nth-child(1)}) still not visible after 1.0000000000000001e-11 sec

Here is some sample source code of how we use .config. We confirmed that removing this fixed the issue:

Feature('Admin - XXXXX').config({
    // Required for all admin tests
    url: process.env.CI ? CONSTANTS.frontendUrls.admin.internal : CONSTANTS.frontendUrls.admin.external
});

Details

• CodeceptJS version: Codecept v2.3.5
• NodeJS Version: Node v12.10.0
• Operating System: Ubuntu 18.04.03 LTS
• Protractor || WebDriverIO || Nightmare version: Webdriver 5.13.2
• Configuration file: The only important bit is that under our helpers we specify:

waitForTimeout: 10000

[mirao]

I'm seeing the same issue with Appium in CodeceptJS 2.6.8, WebDriver 6.1.11, Appium 1.15.1

Workaround for fixing of next scenarios: Reset timeout by this code in _before() in your custom helper (adjust to "WebDriver" if needed):

before() {
   const appium = require("codeceptjs").container.helpers("Appium"); // https://codecept.io/hooks/#container
   appium.options.waitForTimeout = appium.config.waitForTimeout / 1000;
}

[mirao]

It's related to

CodeceptJS/lib/helper/WebDriver.js

Line 465 in 4193663

config.waitForTimeout /= 1000; // convert to seconds

The same issue is with Appium:

CodeceptJS/lib/helper/Appium.js

Line 190 in 4193663

config.waitForTimeout /= 1000; // convert to seconds

I guess that computing msec => sec should occur only when test suite starts. But now it's happening from some reason also when particular scenario with dynamic config starts.

[mirao]

oldConfig.waitForTimeout *= 1000;

after

CodeceptJS/lib/listener/config.js

Line 18 in 4193663

const oldConfig = { ...helper.options };

seems to be a solution.

I'll create PR.

[mirao]

It seems to be fixed in #3478